Update Qi UTXO related types #204
Merged
+129
−130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileystephens28
force-pushed
the
utxo-type-update
branch
from
2b89faa to
7e058a4
Compare
src/wallet/qi-hdwallet.ts
Outdated
| throw new Error(`Account ${info.account} not found in wallet`); | ||
| } | ||
| // validate Outpoint | ||
| if (info.outpoint.Txhash == null || info.outpoint.Index == null || info.outpoint.Denomination == null) { |
There was a problem hiding this comment.
Need to replace properties name here with lowercase (i.e. txhash, index, denomination
src/providers/provider-jsonrpc.ts
Outdated
|
|
||
| import type { PerformActionRequest, Subscriber, Subscription } from './abstract-provider.js'; | ||
| import type { Networkish } from './network.js'; | ||
| import type { TransactionRequest } from './provider.js'; | ||
| import type { Provider, QuaiTransactionRequest, TransactionRequest, TransactionResponse } from './provider.js'; | ||
| import { UTXOEntry, UTXOTransactionOutput } from '../transaction/utxo.js'; |
There was a problem hiding this comment.
UTXOEntry and UTXOTransactionOutput are unused imports
src/providers/provider-jsonrpc.ts
Outdated
| (async () => { | ||
| const address = await resolveAddress(hexlify(tx.outputs![i].address)); | ||
| tx.outputs![i].address = getBytes(address); | ||
| })(), |
There was a problem hiding this comment.
Compile error:
error TS2322: Type 'Uint8Array' is not assignable to type 'string'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial pass at updating UTXO related types. These changed are currently untested.